Fix error handling in inprocess back-end
#176
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
"Broken Pipe" means the receiver end is closed -- it's just wrong to signal this error when receiving from a closed sender. (Admittedly, `Connection Reset` for closed sender is rather arbitrary: a closed sender is normally signalled as EOF, not as an error, by the OS... But it's what the other back-ends use -- and it's better than "Broken Pipe" at any rate.)
Member
|
@bors-servo r+ |
Contributor
|
📌 Commit e438c8a has been approved by |
Contributor
bors-servo
pushed a commit
that referenced
this pull request
Nov 4, 2017
Fix error handling in `inprocess` back-end Two fixes (along with test cases) for handling of sender/receiver closed conditions.
Contributor
|
☀️ Test successful - status-appveyor, status-travis |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Two fixes (along with test cases) for handling of sender/receiver closed conditions.