Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upOpenBSD & NetBSD support #185
Closed
Conversation
Requires accounting for ancillary data in sending data. 63+ fd tests are disabled, since this blocks on OpenBSD. Also requires splitting sends and receives into separate threads during testing.
|
Thanks for the pull request, and welcome! The Servo team is excited to review your changes, and you should hear from @emilio (or someone else) soon. |
| // Empirically, we have to deduct 32 bytes from that. | ||
| const RESERVED_SIZE: usize = 32; | ||
| // Empirically, we have to deduct 72 bytes from that. | ||
| const RESERVED_SIZE: usize = 72; |
This comment has been minimized.
This comment has been minimized.
| @@ -94,11 +94,16 @@ fn medium_data() { | |||
| let data: Vec<u8> = (0..65536).map(|i| (i % 251) as u8).collect(); | |||
| let data: &[u8] = &data[..]; | |||
| let (tx, rx) = platform::channel().unwrap(); | |||
| tx.send(data, vec![], vec![]).unwrap(); | |||
| let thread = thread::spawn(move || { | |||
This comment has been minimized.
This comment has been minimized.
|
|
|
Closing due to lack of response. We're merging basic changes that allow the crate to build on OpenBSD; if there are still changes required for running tests, we can accept a separate PR to address those. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
worr commentedJan 1, 2018
Requires accounting for ancillary data in sending data. 63+ fd tests
are disabled, since this blocks on OpenBSD.
Also requires splitting sends and receives into separate threads during
testing.