Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upUse `::libc::c_char` instead of `i8` #2
Merged
Conversation
|
Conflicts now with my Linux rewrite; could you redo this? Thanks :) |
Some platforms have unsigned chars, there using `i8` causes compilation errors.
|
Redone :) |
pcwalton
added a commit
that referenced
this pull request
Jul 22, 2015
Use `::libc::c_char` instead of `i8`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
akosthekiss commentedJul 22, 2015
Some platforms have unsigned chars, there using
i8causescompilation errors.