Skip to content

/ ipc-channel

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Derive Debug on some of the public types #21

Merged
merged 1 commit into from Dec 24, 2015
Merged

Derive Debug on some of the public types #21

merged 1 commit into from Dec 24, 2015

Conversation

@antrik
Copy link
Contributor

antrik commented Dec 13, 2015

Some of the types already have had working Debug implementations (or
derives) available in all the OS-specific backends; but for some reason
they were not exposed on the (portable) API types... Let's change that.

Note that this doesn't cover all of the public types -- some would
actually need Debug implementations to be newly introduced for all the
OS-specific backends, which would be much more involved than just
exposing the existing ones...

This is not tested on MacOS; however, the backends seem to be very symmetric -- so hopefully it should just work...
@KiChjang
Copy link
Member

KiChjang commented Dec 13, 2015

@bors-servo try
@bors-servo
Copy link
Contributor

bors-servo commented Dec 13, 2015

⌛ Trying commit 89ddf77 with merge 7184030...
bors-servo added a commit that referenced this pull request Dec 13, 2015
@bors-servo
Auto merge of #21 - antrik:debug, r=<try>
Loading status checks…
7184030 
Derive Debug on some of the public types

Some of the types already have had working Debug implementations (or
derives) available in all the OS-specific backends; but for some reason
they were not exposed on the (portable) API types... Let's change that.

Note that this doesn't cover all of the public types -- some would
actually need Debug implementations to be newly introduced for all the
OS-specific backends, which would be much more involved than just
exposing the existing ones...

This is not tested on MacOS; however, the backends seem to be very symmetric -- so hopefully it should just work...
@bors-servo
Copy link
Contributor

bors-servo commented Dec 13, 2015

💔 Test failed - travis
@wafflespeanut
Copy link
Member

wafflespeanut commented Dec 13, 2015

huh

platform/linux/mod.rs:23:5: 23:41 error: unresolved import `std::slice::bytes::MutableByteVector`. Could not find `bytes` in `std::slice` [E0432]

platform/linux/mod.rs:23 use std::slice::bytes::MutableByteVector;

                             ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
@antrik
Copy link
Contributor Author

antrik commented Dec 13, 2015

Hrm. The auto-builder appears to be using a different Rust snapshot than Servo. I actually got similar errors (unrelated to my changes I'm quite sure) when compiling locally with a different snapshot; but it builds fine when using the same compiler as Servo...
@antrik
Copy link
Contributor Author

antrik commented Dec 15, 2015

It builds again (both master and my branch) with current nightly.
@antrik
Copy link
Contributor Author

antrik commented Dec 16, 2015

[knock knock] Anyone there?...
@frewsxcv
Copy link
Member

frewsxcv commented Dec 23, 2015

@bors-servo retry clean
@larsbergstrom
Copy link
Contributor

larsbergstrom commented Dec 23, 2015

r? @pcwalton
@frewsxcv
Copy link
Member

frewsxcv commented Dec 23, 2015

@bors-servo retry
@pcwalton
Copy link
Collaborator

pcwalton commented Dec 23, 2015

@bors-servo: r+
@antrik
Derive Debug on some of the public types
Loading status checks…
410a614 
Some of the types already have had working Debug implementations (or
derives) available in all the OS-specific backends; but for some reason
they were not exposed on the (portable) API types... Let's change that.

Note that this doesn't cover all of the public types -- some would
actually need Debug implementations to be newly introduced for all the
OS-specific backends, which would be much more involved than just
exposing the existing ones...
@antrik antrik force-pushed the antrik:debug branch from 89ddf77 to 410a614 Dec 23, 2015
@pcwalton
Copy link
Collaborator

pcwalton commented Dec 23, 2015

@bors-servo: r+
@frewsxcv frewsxcv closed this Dec 23, 2015
@frewsxcv frewsxcv reopened this Dec 23, 2015
@frewsxcv
Copy link
Member

frewsxcv commented Dec 23, 2015

@bors-servo r=pcwalton
@bors-servo
Copy link
Contributor

bors-servo commented Dec 23, 2015

📌 Commit 410a614 has been approved by pcwalton
@bors-servo
Copy link
Contributor

bors-servo commented Dec 23, 2015

⌛ Testing commit 410a614 with merge b963e7f...
bors-servo added a commit that referenced this pull request Dec 23, 2015
@bors-servo
Auto merge of #21 - antrik:debug, r=pcwalton
Loading status checks…
b963e7f 
Derive Debug on some of the public types

Some of the types already have had working Debug implementations (or
derives) available in all the OS-specific backends; but for some reason
they were not exposed on the (portable) API types... Let's change that.

Note that this doesn't cover all of the public types -- some would
actually need Debug implementations to be newly introduced for all the
OS-specific backends, which would be much more involved than just
exposing the existing ones...

This is not tested on MacOS; however, the backends seem to be very symmetric -- so hopefully it should just work...
@bors-servo
Copy link
Contributor

bors-servo commented Dec 23, 2015

💔 Test failed - travis
@frewsxcv
Copy link
Member

frewsxcv commented Dec 23, 2015

Aster doesn't compile on nightly: serde-deprecated/aster#58
@frewsxcv
Copy link
Member

frewsxcv commented Dec 24, 2015

@bors-servo r=pcwalton
@bors-servo
Copy link
Contributor

bors-servo commented Dec 24, 2015

📌 Commit 410a614 has been approved by pcwalton
@frewsxcv
Copy link
Member

frewsxcv commented Dec 24, 2015

@bors-servo retry
@bors-servo
Copy link
Contributor

bors-servo commented Dec 24, 2015

⌛ Testing commit 410a614 with merge 130335f...
bors-servo added a commit that referenced this pull request Dec 24, 2015
@bors-servo
Auto merge of #21 - antrik:debug, r=pcwalton
Loading status checks…
130335f 
Derive Debug on some of the public types

Some of the types already have had working Debug implementations (or
derives) available in all the OS-specific backends; but for some reason
they were not exposed on the (portable) API types... Let's change that.

Note that this doesn't cover all of the public types -- some would
actually need Debug implementations to be newly introduced for all the
OS-specific backends, which would be much more involved than just
exposing the existing ones...

This is not tested on MacOS; however, the backends seem to be very symmetric -- so hopefully it should just work...
@bors-servo
Copy link
Contributor

bors-servo commented Dec 24, 2015

☀️ Test successful - travis
@bors-servo bors-servo merged commit 410a614 into servo:master Dec 24, 2015
1 check passed
1 check passed
homu Test successful
Details
@antrik antrik mentioned this pull request Dec 26, 2015
Merged
antrik added a commit to antrik/ipc-channel that referenced this pull request Dec 26, 2015
@antrik
Fix: Provide dummy Debug impls for platform::inprocess::{MpscSender, …
e9d1450 
…MpscReceiver}

Fixes a regression introduced by
410a614 (
servo#21 ), which broke compilation
for targets using the inprocess backend.
@antrik antrik mentioned this pull request Dec 26, 2015
Merged
antrik added a commit to antrik/ipc-channel that referenced this pull request Dec 26, 2015
@antrik
Fix: Provide dummy Debug impls for platform::inprocess::{MpscSender, …
0dc39fb 
…MpscReceiver}

Fixes a regression introduced by
410a614 (
servo#21 ), which broke compilation
for targets using the inprocess backend.
bors-servo added a commit that referenced this pull request Dec 28, 2015
@bors-servo
Auto merge of #22 - antrik:fix-debug, r=<try>
Loading status checks…
be6f2cb 
Fix: Provide dummy Debug impls for platform::inprocess::{MpscSender, …

…MpscReceiver}

Fixes a regression introduced by
410a614 (
#21 ), which broke compilation
for targets using the inprocess backend.
bors-servo added a commit that referenced this pull request Dec 28, 2015
@bors-servo
Auto merge of #22 - antrik:fix-debug, r=larsbergstrom
Loading status checks…
1b95d54 
Fix: Provide dummy Debug impls for platform::inprocess::{MpscSender, …

…MpscReceiver}

Fixes a regression introduced by
410a614 (
#21 ), which broke compilation
for targets using the inprocess backend.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

7 participants
@antrik @KiChjang @bors-servo @wafflespeanut @frewsxcv @larsbergstrom @pcwalton
You can’t perform that action at this time.