Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upReplacing unsafe mktemp with mkdtemp to avoid linux compiler errors #28
Conversation
platform/linux/mod.rs
Outdated
| @@ -927,4 +930,3 @@ struct pollfd { | |||
| events: c_short, | |||
| revents: c_short, | |||
| } | |||
|
|
|||
This comment has been minimized.
This comment has been minimized.
|
After getting the latest dependencies from |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
craftytrickster commentedJan 15, 2016
I am unable to compile servo on my linux laptop anymore due the following issue - which is caused by the inclusion of mktemp.
Unfortuntately, using mkstemp is not a viable solution, since it actually opens a handle on the newly created file, which causes libc bind to fail. As a workaround, I thought of using mkdtemp, which safely creates a random directory, and then just adding a file there to use. I have not worked with these libc functions before, so if I am overlooking something please let me know.