Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't panic on Linux when shmem is zero-sized. #44

Merged
merged 1 commit into from Mar 4, 2016

Conversation

@pcwalton
Copy link
Collaborator

pcwalton commented Mar 4, 2016

@@ -32,6 +32,9 @@ const DEV_NULL_RDEV: libc::dev_t = 0x0103;

const MAX_FDS_IN_CMSG: u32 = 64;

// Yes, really!
const MAP_FAILED: *mut u8 = (!0) as usize as *mut u8;

This comment has been minimized.

@mbrubeck

mbrubeck Mar 4, 2016

I'd prefer to write this !0usize as *mut u8 for clarity.

@pcwalton pcwalton force-pushed the pcwalton:zero-sized-shmem branch from 06d1891 to 32a4ee4 Mar 4, 2016
@mbrubeck
Copy link

mbrubeck commented Mar 4, 2016

@bors-servo
Copy link
Contributor

bors-servo commented Mar 4, 2016

📌 Commit 32a4ee4 has been approved by mbrubeck

bors-servo added a commit that referenced this pull request Mar 4, 2016
Don't panic on Linux when shmem is zero-sized.

r? @mbrubeck
@bors-servo
Copy link
Contributor

bors-servo commented Mar 4, 2016

Testing commit 32a4ee4 with merge 0563c9f...

@bors-servo
Copy link
Contributor

bors-servo commented Mar 4, 2016

☀️ Test successful - travis

@bors-servo bors-servo merged commit 32a4ee4 into servo:master Mar 4, 2016
2 of 3 checks passed
2 of 3 checks passed
continuous-integration/appveyor/pr Waiting for AppVeyor build to complete
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
homu Test successful
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.