Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix zero-sized shared memory leaking FD on drop (due to len=0 making … #47

Merged
merged 1 commit into from Mar 9, 2016

Conversation

@glennw
Copy link
Member

glennw commented Mar 8, 2016

…mmap fail).

Fixes #45.

@glennw
Copy link
Member Author

glennw commented Mar 8, 2016

@pcwalton
Copy link
Collaborator

pcwalton commented Mar 8, 2016

@bors-servo
Copy link
Contributor

bors-servo commented Mar 8, 2016

📌 Commit c9406db has been approved by pcwalton

@bors-servo
Copy link
Contributor

bors-servo commented Mar 8, 2016

Testing commit c9406db with merge 3be1d4d...

bors-servo added a commit that referenced this pull request Mar 8, 2016
Fix zero-sized shared memory leaking FD on drop (due to len=0 making …

…mmap fail).

Fixes #45.
@pcwalton
Copy link
Collaborator

pcwalton commented Mar 8, 2016

Doh! Nice catch.

@bors-servo
Copy link
Contributor

bors-servo commented Mar 8, 2016

💔 Test failed - travis

@glennw
Copy link
Member Author

glennw commented Mar 9, 2016

@bors-servo retry

@bors-servo
Copy link
Contributor

bors-servo commented Mar 9, 2016

Testing commit c9406db with merge e6d0164...

bors-servo added a commit that referenced this pull request Mar 9, 2016
Fix zero-sized shared memory leaking FD on drop (due to len=0 making …

…mmap fail).

Fixes #45.
@bors-servo
Copy link
Contributor

bors-servo commented Mar 9, 2016

☀️ Test successful - travis

@bors-servo bors-servo merged commit c9406db into servo:master Mar 9, 2016
0 of 3 checks passed
0 of 3 checks passed
continuous-integration/appveyor/pr AppVeyor build failed
Details
continuous-integration/travis-ci/pr The Travis CI build failed
Details
homu Testing commit c9406db with merge e6d0164...
Details
@glennw glennw deleted the glennw:fix-leak branch Mar 9, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
You can’t perform that action at this time.