Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upIntroduce `IpcBytesSender` and `IpcBytesReceiver` types for fast transfer of binary blobs. #50
+117
−3
Conversation
|
Updated with tests. |
ipc.rs
Outdated
| let index: usize = try!(Deserialize::deserialize(deserializer)); | ||
| let os_receiver = | ||
| OS_IPC_CHANNELS_FOR_DESERIALIZATION.with(|os_ipc_channels_for_deserialization| { | ||
| // FIXME(pcwalton): This could panic. Return some sort of nice error. |
This comment has been minimized.
This comment has been minimized.
|
Otherwise this looks good to me. |
|
Updated the comment and all of the corresponding comments in the file to be more precise. r? @jdm |
transfer of binary blobs. `serde`/`bincode` is very slow at serializing and deserializing `Vec<u8>`, and shared memory involves too many syscalls (at least on the Mac).
|
@bors-servo: r+ |
|
|
bors-servo
added a commit
that referenced
this pull request
Mar 10, 2016
|
|
|
@bors-servo: retry |
bors-servo
added a commit
that referenced
this pull request
Mar 18, 2016
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
pcwalton commentedMar 10, 2016
serde/bincodeis very slow at serializing and deserializingVec<u8>, and shared memory involves too many syscalls (at least on theMac).
r? @jdm