Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign uptests: Wait for forked child processes #53
Merged
Conversation
Don't leave zombie processes around -- they hinder debugging, and might have other harmful side effects as well.
|
Refactored variant. Let's hope I didn't break Windows build... |
|
I don't think it's unsafe, but it doesn't really matter. |
|
@bors-servo: r+ |
|
@bors-servo r=pcwalton |
|
@bors-servo r=pcwalton |
|
|
bors-servo
added a commit
that referenced
this pull request
Mar 20, 2016
tests: Wait for forked child processes Don't leave zombie processes around -- they hinder debugging, and might have other harmful side effects as well.
|
|
| ///XXXjdm Windows' libc doesn't include fork. | ||
| #[cfg(not(windows))] | ||
| // I'm not actually sure invoking this is indeed unsafe -- but better safe than sorry... | ||
| pub unsafe fn fork<F: FnOnce()>(child_func: F) -> libc::pid_t { |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
antrik
Mar 20, 2016
Author
Contributor
For the record: I actually think so too; but because of language limitations, this can currently be only achieved by using the Void crate -- which @pcwalton didn't want.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
antrik commentedMar 19, 2016
Don't leave zombie processes around -- they hinder debugging, and might
have other harmful side effects as well.