Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign uprun tidy #67
Closed
run tidy #67
Conversation
|
Note: this can't merge until the things that tidy reports are fixed, since it breaks the TravisCI build. |
waiting on servo/servo#10715 and/or resolution to servo/servo#10716
|
Wow, nice work - that was a pretty epic but tedious change. r=me once the license thing is fixed up. |
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
edunham commentedApr 19, 2016
for servo/servo#10636
It currently needs a lot of manual tidying-up, and rustfmt can't handle the line lengths (see rust-lang/rustfmt#611).
Applying the changes suggested by tidy is onerous but not particularly confusing, so I'll file it as an easy issue for now.
r? @larsbergstrom