Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upLinux: Always retry with an actually smaller size on `ENOBUFS` #69
Conversation
Previously, if we got `ENOBUFS` while the packet we tried to send was already less than half the maximum send buffer size, we would end up with a new buffer size that was still larger than the actual packet... Aside from being nonsensical, this would actually result in buggy behaviour if the message was smaller than half the buffer size to begin with, as the fragmented send code works from the assumption that the message is larger than the fragment size, and will fail otherwise. (In my testing, I never actually got `ENOBUFS` with packets smaller than half the maximum buffer size -- but let's assume we might...)
|
AppVeyor having a bad day?... |
metajack
commented
May 5, 2016
|
r? @pcwalton |
|
@bors-servo: r+ |
|
|
bors-servo
added a commit
that referenced
this pull request
May 6, 2016
Linux: Always retry with an actually smaller size on `ENOBUFS` Previously, if we got `ENOBUFS` while the packet we tried to send was already less than half the maximum send buffer size, we would end up with a new buffer size that was still larger than the actual packet... Aside from being nonsensical, this would actually result in buggy behaviour if the message was smaller than half the buffer size to begin with, as the fragmented send code works from the assumption that the message is larger than the fragment size, and will fail otherwise. (In my testing, I never actually got `ENOBUFS` with packets smaller than half the maximum buffer size -- but let's assume we might...)
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
antrik commentedMay 5, 2016
Previously, if we got
ENOBUFSwhile the packet we tried to send wasalready less than half the maximum send buffer size, we would end up
with a new buffer size that was still larger than the actual packet...
Aside from being nonsensical, this would actually result in buggy
behaviour if the message was smaller than half the buffer size to begin
with, as the fragmented send code works from the assumption that the
message is larger than the fragment size, and will fail otherwise.
(In my testing, I never actually got
ENOBUFSwith packets smaller thanhalf the maximum buffer size -- but let's assume we might...)