Skip to content

/ ipc-channel

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

platform/tests: cleanup: drop `truncate()` calls on received data #79

Closed
wants to merge 3 commits into from
Closed

platform/tests: cleanup: drop `truncate()` calls on received data #79

wants to merge 3 commits into from

Conversation

@antrik
Copy link
Contributor

antrik commented Jun 1, 2016

I really can't think of any purpose these might serve...
@metajack
Copy link

metajack commented Jun 1, 2016

r? @pcwalton
@emilio
Copy link
Member

emilio commented Jun 1, 2016

Looking at the output of the build, it seems truncate() makes a difference on OSX.
@antrik antrik force-pushed the antrik:cleanup-tests-truncate branch from 6650cd3 to 7ffb703 Jun 5, 2016
@antrik
Copy link
Contributor Author

antrik commented Jun 5, 2016

Interesting... Let me check something.
antrik added 3 commits Jun 5, 2016
@antrik
MacOS: Don't pad message size to multiples of 4 bytes
effdcca 
This avoids undesired padding when using `bytes_channel` with an odd
size; and I fail to see why such padding in the Mach message would be
beneficial, anyway?...
@antrik
test: bytes: Use an odd number of bytes
988a503 
This should help catching alignment-related problems...
@antrik
platform/tests: cleanup: drop `truncate()` calls on received data
Loading status checks…
3d1be1f 
I really can't think of any purpose these might serve...
@antrik antrik force-pushed the antrik:cleanup-tests-truncate branch from 7ffb703 to 3d1be1f Jun 5, 2016
@antrik
Copy link
Contributor Author

antrik commented Jun 5, 2016

Yeah, guessed so... So normally it doesn't matter that the macos backend introduces trailing zeros, as they are simply ignored during deserialisation; but with bytes_channel, this is now exposed to the public...

Now let's try another thing...
@antrik
Copy link
Contributor Author

antrik commented Jun 5, 2016

Meh. No idea how to fix this.
@emilio
Copy link
Member

emilio commented Jun 29, 2016

@antrik: I'm closing this since it seems inactive. Feel free to reopen if you find a solution :/
@emilio emilio closed this Jun 29, 2016
@antrik
Copy link
Contributor Author

antrik commented Jun 29, 2016

Heh, funny timing: I wanted to close it myself right now, as not being an Apple worshipper err I mean developer, there is nothing I can do about this...

I opened a bug report instead ( #83 ), for someone else to take care of.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
@antrik @metajack @emilio
You can’t perform that action at this time.