Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upBump up the size of the internal Mach buffer to the maximum. #8
Conversation
The default is 5 messages before blocking. This is too few in practice and causes deadlocks in iframe reftests. The maximum is 1024, which ought to be enough.
|
This sounds good. I believe it's even worse than 5, from what I can tell - in OSX 10.10, while the constant for the default is still 5, the internal default is reported to have changed to 2, which may be why we're seeing more of these blocking issues recently. Moving to the default "large" value of 1024 seems like the right thing to do here. @bors-servo r+ |
pcwalton
added a commit
that referenced
this pull request
Sep 30, 2015
Bump up the size of the internal Mach buffer to the maximum.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
pcwalton commentedSep 30, 2015
The default is 5 messages before blocking. This is too few in practice
and causes deadlocks in iframe reftests. The maximum is 1024, which
ought to be enough.
r? @larsbergstrom