Skip to content

/ ipc-channel

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

linux: Replace some FFI definitions with libc imports #80

Merged
merged 1 commit into from Jun 29, 2016
Merged

linux: Replace some FFI definitions with libc imports #80

merged 1 commit into from Jun 29, 2016
+17 −68

Conversation

@kamalmarhubi
Copy link
Contributor

kamalmarhubi commented Jun 9, 2016

No description provided.

@kamalmarhubi
Copy link
Contributor Author

kamalmarhubi commented Jun 9, 2016

SOCK_SEQPACKET will be able to go at the next libc release, too.
@kamalmarhubi
linux: Replace some FFI definitions with libc imports
Loading status checks…
d9e2ed0
@kamalmarhubi
Copy link
Contributor Author

kamalmarhubi commented Jun 10, 2016

libc 0.2.12 is out so I bumped it and dropped SOCK_SEQPACKET.
@kamalmarhubi kamalmarhubi force-pushed the kamalmarhubi:use-libc-defns branch from 11f1f9d to d9e2ed0 Jun 10, 2016
@emilio
Copy link
Member

emilio commented Jun 28, 2016

This looks good to me, thanks for doing this, and sorry for the extreme delay in reviewing this.

Could you remove all the explicit pointer casts for as *mut _/as *const _ when possible? If for some reason you can't, let's merge it and I'll do it as a followup.

Thanks (and sorry) again! :)
@kamalmarhubi
Copy link
Contributor Author

kamalmarhubi commented Jun 28, 2016

@emilio no worries about the delay!

Re casts, I don't think any of them can be removed. A cast is needed to go from &T to *T, and then another from *T to *c_void. I tried removing a couple and it complained.

If you do remove them as a followup, please ping me in the PR so I can see what you did!
@emilio
Copy link
Member

emilio commented Jun 29, 2016

@kamalmarhubi ok, fair enough :)

Thanks again!

@bors-servo: r+
@bors-servo
Copy link
Contributor

bors-servo commented Jun 29, 2016

📌 Commit d9e2ed0 has been approved by emilio
@bors-servo
Copy link
Contributor

bors-servo commented Jun 29, 2016

⌛ Testing commit d9e2ed0 with merge 55fff81...
bors-servo added a commit that referenced this pull request Jun 29, 2016
@bors-servo
Auto merge of #80 - kamalmarhubi:use-libc-defns, r=emilio
Loading status checks…
55fff81 
linux: Replace some FFI definitions with libc imports
@bors-servo
Copy link
Contributor

bors-servo commented Jun 29, 2016

☀️ Test successful - status-appveyor, travis
@bors-servo bors-servo merged commit d9e2ed0 into servo:master Jun 29, 2016
1 of 3 checks passed
1 of 3 checks passed
continuous-integration/appveyor/pr AppVeyor build failed
Details
continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
homu Test successful
Details
@antrik
Copy link
Contributor

antrik commented Jun 29, 2016

@kamalmarhubi is there any fundamental reason not to move the remaining FFI definitions to libc as well?
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
@kamalmarhubi @emilio @bors-servo @antrik
You can’t perform that action at this time.