Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upIntroduce an inprocess feature #82
Conversation
This means we don't need to import all types by hand for each platform in platform/mod.rs.
|
Note that appveyor was introduced to build the in-process code, so please ensure that that continues to be the case. |
| mod inprocess; | ||
| pub use self::os::{OsIpcChannel, OsIpcOneShotServer, OsIpcReceiver, OsIpcReceiverSet}; | ||
| pub use self::os::{OsIpcSelectionResult, OsIpcSender, OsIpcSharedMemory}; | ||
| pub use self::os::{OsOpaqueIpcChannel, channel}; |
This comment has been minimized.
This comment has been minimized.
antrik
Jun 29, 2016
Contributor
I guess that's a matter of taste -- but I strongly dislike the arbitrary split of the use statements... Is there any kind of style guide regarding this?
This comment has been minimized.
This comment has been minimized.
nox
Jun 29, 2016
Author
Member
That's just the exact same split as we use in Servo, keeping lines not too long and not doing multiline use statements.
This comment has been minimized.
This comment has been minimized.
antrik
Jun 29, 2016
Contributor
I'm not sure what's wrong with multiline use statements... But I can live with that I guess.
Still, I think it would be vastly preferable to group the types in some logical manner. As it is, it is (subjectively) confusing, and (objectively) a PITA if another entry ever needs to be added...
I guess that's bikeshedding though -- feel free to disregard :-)
This comment has been minimized.
This comment has been minimized.
nox
Jun 29, 2016
Author
Member
There is no "logical manner" that fits all of us, so we chose alphabetical order.
metajack
commented
Jul 6, 2016
|
r? @pcwalton |
|
@bors-servo: r+ Nice! This is a great cleanup. |
|
|
Introduce an inprocess feature
|
|
nox commentedJun 29, 2016
No description provided.