Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upwin32 build fixes; find fontconfig via pkg-config if it's an appropriate version #17
Conversation
…iate version
|
@bors-servo r+ It occurs to me that if 2.11.1 is widely deployed now, we can probably get rid of our crate entirely. At the time we made it, it wasn't in any of the distros yet. Reviewed 2 of 2 files at r1. Comments from the review on Reviewable.io |
all files reviewed at latest revision, all discussions resolved, all commit checks successful.
|
|
bors-servo
pushed a commit
that referenced
this pull request
Sep 24, 2015
win32 build fixes; find fontconfig via pkg-config if it's an appropriate version This uses pkg-config to see if the system already has fontconfig built, and if so just uses it. <!-- Reviewable:start --> [<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/libfontconfig/17) <!-- Reviewable:end -->
|
|
bors-servo
merged commit d1a1718
into
servo:master
1 check was pending
1 check was pending
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
vvuk commentedSep 24, 2015
This uses pkg-config to see if the system already has fontconfig built, and if so just uses it.