Skip to content

/ libfontconfig

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add `INCDIR` for downstream crates and add a `links` directive to `Cargo.toml`. #19

Merged
merged 1 commit into from Jan 20, 2016
Merged

Add `INCDIR` for downstream crates and add a `links` directive to `Cargo.toml`. #19

merged 1 commit into from Jan 20, 2016
+4 −2

Conversation

@DiamondLovesYou
Copy link
Contributor

DiamondLovesYou commented Jan 7, 2016

Review on Reviewable
@DiamondLovesYou
Add `INCDIR` for downstream crates and add a `links` directive to `Ca…
Loading status checks…
e67e3c8 
…rgo.toml`.
@larsbergstrom
Copy link
Contributor

larsbergstrom commented Jan 15, 2016

The links line seems fine, but what is the cargo:incdir variable for? I don't see it in http://doc.crates.io/build-script.html or the sources/issues in rust-lang/cargo.
@larsbergstrom larsbergstrom self-assigned this Jan 15, 2016
@DiamondLovesYou
Copy link
Contributor Author

DiamondLovesYou commented Jan 15, 2016

It creates a DEP_FONTCONFIG_INCDIR env var for downstream dependencies to use.
@mbrubeck
Copy link
Contributor

mbrubeck commented Jan 20, 2016

@bors-servo r+
@bors-servo
Copy link
Contributor

bors-servo commented Jan 20, 2016

📌 Commit e67e3c8 has been approved by mbrubeck
@bors-servo
Copy link
Contributor

bors-servo commented Jan 20, 2016

⌛ Testing commit e67e3c8 with merge 43a382c...
bors-servo added a commit that referenced this pull request Jan 20, 2016
@bors-servo
Auto merge of #19 - DiamondLovesYou:master, r=mbrubeck
Loading status checks…
43a382c 
Add `INCDIR` for downstream crates and add a `links` directive to `Cargo.toml`.

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/libfontconfig/19)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Jan 20, 2016

☀️ Test successful - travis
@bors-servo bors-servo merged commit e67e3c8 into servo:master Jan 20, 2016
1 check passed
1 check passed
homu Test successful
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@larsbergstrom larsbergstrom

Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
@DiamondLovesYou @larsbergstrom @mbrubeck @bors-servo
You can’t perform that action at this time.