Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upUse a new version that sorts correctly with all SemVer libraries #21
+1
−1
Conversation
|
@bors-servo r+ |
|
|
bors-servo
added a commit
that referenced
this pull request
Feb 3, 2016
Use a new version that sorts correctly with all SemVer libraries r? @SimonSapin @Manishearth The `2-really.1` is no longer parsed in a correct order by semver (it is LOWER than `1`). This prevents updating cargo: servo/servo#9314 <!-- Reviewable:start --> [<img src="https://reviewable.io/review_button.svg" height="40" alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/libfontconfig/21) <!-- Reviewable:end -->
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
larsbergstrom commentedFeb 3, 2016
r? @SimonSapin @Manishearth
The
2-really.1is no longer parsed in a correct order by semver (it is LOWER than1). This prevents updating cargo: servo/servo#9314