Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upFix up cross-compilation issues #22
Merged
Conversation
makefile.cargo
Outdated
| @@ -23,6 +23,12 @@ AR ?= ar | |||
|
|
|||
| endif | |||
|
|
|||
| ifeq ("$(MSYSTEM)","") | |||
| CXXFLAGS += -fPIC | |||
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
vvuk
Jun 24, 2016
Author
Contributor
I'm pretty sure -fPIC is a no-op on Windows, due to the ABI. This builds, at least.
|
r=me once we resolve the -fPIC thing. |
|
@bors-servo r+ Reviewed 1 of 1 files at r1. Comments from Reviewable |
|
|
bors-servo
added a commit
that referenced
this pull request
Jul 11, 2016
Fix up cross-compilation issues Fix a few cross-compilation issues. This won't actually be used with MSVC builds, but fixes Android issue. <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/libfontconfig/22) <!-- Reviewable:end -->
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
vvuk commentedJun 22, 2016
•
edited by larsbergstrom
Fix a few cross-compilation issues. This won't actually be used with MSVC builds, but fixes Android issue.
This change is