Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix intermittent build error #42

Merged
merged 2 commits into from Dec 5, 2019
Merged

Fix intermittent build error #42

merged 2 commits into from Dec 5, 2019

Conversation

@jdm
Copy link
Member

jdm commented Dec 5, 2019

This is a symptom of a change in Cargo (rust-lang/cargo#7465) that no longer preserves the mtime of files extracted during the package download process. This means that generated files included in this repository can end up being regenerated unnecessarily unless we explicitly force them to be treated as more recent than their source files.

jdm added 2 commits Dec 5, 2019
@asajeffrey
Copy link
Member

asajeffrey commented Dec 5, 2019

@bors-servo
Copy link
Contributor

bors-servo commented Dec 5, 2019

📌 Commit e02e81c has been approved by asajeffrey

bors-servo added a commit that referenced this pull request Dec 5, 2019
Fix intermittent build error

This is a symptom of a change in Cargo (rust-lang/cargo#7465) that no longer preserves the mtime of files extracted during the package download process. This means that generated files included in this repository can end up being regenerated unnecessarily unless we explicitly force them to be treated as more recent than their source files.
@bors-servo
Copy link
Contributor

bors-servo commented Dec 5, 2019

Testing commit e02e81c with merge 38e028e...

@bors-servo
Copy link
Contributor

bors-servo commented Dec 5, 2019

☀️ Test successful - checks-travis
Approved by: asajeffrey
Pushing 38e028e to master...

@bors-servo bors-servo merged commit e02e81c into master Dec 5, 2019
2 checks passed
2 checks passed
Travis CI - Branch Build Passed
Details
homu Test successful
Details
@jdm jdm mentioned this pull request Dec 6, 2019
4 of 4 tasks complete
bors-servo added a commit to servo/servo that referenced this pull request Dec 9, 2019
Fix intermittent android build error

Incorporates servo/libfontconfig#42.

- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [x] These changes fix #24715
- [x] There are tests for these changes
bors-servo added a commit to servo/servo that referenced this pull request Dec 9, 2019
Fix intermittent android build error

Incorporates servo/libfontconfig#42.

- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [x] These changes fix #24715
- [x] There are tests for these changes
bors-servo added a commit to servo/servo that referenced this pull request Dec 9, 2019
Fix intermittent android build error

Incorporates servo/libfontconfig#42.

- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [x] These changes fix #24715
- [x] There are tests for these changes
bors-servo added a commit to servo/servo that referenced this pull request Dec 9, 2019
Fix intermittent android build error

Incorporates servo/libfontconfig#42.

- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [x] These changes fix #24715
- [x] There are tests for these changes
bors-servo added a commit to servo/servo that referenced this pull request Dec 9, 2019
Fix intermittent android build error

Incorporates servo/libfontconfig#42.

- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [x] These changes fix #24715
- [x] There are tests for these changes
xeonchen pushed a commit to xeonchen/gecko that referenced this pull request Mar 10, 2020
moz-v2v-gh pushed a commit to mozilla/gecko-dev that referenced this pull request Mar 11, 2020
… errors. r=kvark

The lack of servo/libfontconfig#42 in 4.0.4
broke rust CI

Differential Revision: https://phabricator.services.mozilla.com/D66275

--HG--
extra : moz-landing-system : lando
moz-gfx added a commit to moz-gfx/webrender that referenced this pull request Mar 11, 2020
gecko-dev-updater pushed a commit to marco-c/gecko-dev-comments-removed that referenced this pull request Mar 12, 2020
… errors. r=kvark

The lack of servo/libfontconfig#42 in 4.0.4
broke rust CI

Differential Revision: https://phabricator.services.mozilla.com/D66275

UltraBlame original commit: 399aeed6f2c4f1e4300b3a11ee740464e0e0d5c3
gecko-dev-updater pushed a commit to marco-c/gecko-dev-wordified that referenced this pull request Mar 12, 2020
… errors. r=kvark

The lack of servo/libfontconfig#42 in 4.0.4
broke rust CI

Differential Revision: https://phabricator.services.mozilla.com/D66275

UltraBlame original commit: 399aeed6f2c4f1e4300b3a11ee740464e0e0d5c3
gecko-dev-updater pushed a commit to marco-c/gecko-dev-wordified-and-comments-removed that referenced this pull request Mar 12, 2020
… errors. r=kvark

The lack of servo/libfontconfig#42 in 4.0.4
broke rust CI

Differential Revision: https://phabricator.services.mozilla.com/D66275

UltraBlame original commit: 399aeed6f2c4f1e4300b3a11ee740464e0e0d5c3
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.