Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upGet dependencies' dirs from Cargo metadata #5
+2
−5
Conversation
SimonSapin
added a commit
that referenced
this pull request
May 27, 2015
Get dependencies' dirs from Cargo metadata
Part of servo/servo#6088.
| EXPAT_FLAGS = --with-expat-includes=$(EXPAT_OUTDIR)/include \ | ||
| --with-expat-lib=$(EXPAT_OUTDIR) | ||
| EXPAT_FLAGS = --with-expat-includes="$(DEP_EXPAT_OUTDIR)/include" \ | ||
| --with-expat-lib="$(DEP_EXPAT_OUTDIR)" | ||
| FREETYPE_CFLAGS = -I$(FREETYPE_OUTDIR)/include | ||
| FREETYPE_LIBS = -L$(FREETYPE_OUTDIR) -lfreetype |
This comment has been minimized.
This comment has been minimized.
SimonSapin
May 30, 2015
Member
These two lines need to be updated as well: servo/servo#6218 (comment)
@asbaker, wanna do it?
This comment has been minimized.
This comment has been minimized.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
mbrubeck commentedMay 27, 2015
Part of servo/servo#6088. r? @SimonSapin