Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Full OscillatorNode support #42

Closed
ferjm opened this issue Jun 5, 2018 · 3 comments
Closed

Full OscillatorNode support #42

ferjm opened this issue Jun 5, 2018 · 3 comments

Comments

@ferjm
Copy link
Member

@ferjm ferjm commented Jun 5, 2018

Right now we implement only the generation of sine waves, but there are other sine wave types that we need to implement, including the periodic waveform. This is not a high priority at the moment though.

@jdm
Copy link
Member

@jdm jdm commented Sep 24, 2018

I am reserving this for a group of NCSU students to work on.

@jdm
Copy link
Member

@jdm jdm commented Sep 24, 2018

let value = vol * f32::sin(NumCast::from(self.phase).unwrap());

@ferjm
Copy link
Member Author

@ferjm ferjm commented Dec 5, 2018

Part of this work was completed in #163. The remaining bits are tracked in servo/servo#22364

@ferjm ferjm closed this Dec 5, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants
You can’t perform that action at this time.