Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upAllow the creation of audio graph nodes #11
Merged
Conversation
src/audio/node.rs
Outdated
| DynamicsCompressionNode, | ||
| GainNode, | ||
| IIRFilterNode, | ||
| OscillatorNode, |
This comment has been minimized.
This comment has been minimized.
Manishearth
May 18, 2018
Member
ideally this would be OscillatorNode(f32) where the f32 is the initial frequency.
This comment has been minimized.
This comment has been minimized.
ferjm
May 18, 2018
Author
Member
Should we add the other options as well? https://webaudio.github.io/web-audio-api/#dictdef-oscillatoroptions
This comment has been minimized.
This comment has been minimized.
Manishearth
May 18, 2018
Member
Yeah.
Actually the way I was envisioning this was that DOM code would send Box<AudioNodeEngine> over, and servo-media doesn't know anything about the specific nodes.
This is tricky to make work across a process boundary though, so this works better I guess.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
ferjm commentedMay 18, 2018
No description provided.