Skip to content

/ media

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose number of decoded channels through decoder's eos callback #115

Merged
merged 3 commits into from Aug 27, 2018
Merged

Expose number of decoded channels through decoder's eos callback #115

merged 3 commits into from Aug 27, 2018
+17 −16

Conversation

@ferjm
Copy link
Member

ferjm commented Aug 27, 2018

Fixes #108
ferjm added 3 commits Aug 27, 2018
@ferjm
Get number of channels from decoded audio sample
2fa1560
@ferjm
Remove number of channels from audio decoder options
af79c8d
@ferjm
Pass channel number through decoder eos callback
bfcd03a
@ferjm ferjm requested a review from Manishearth Aug 27, 2018
@ferjm
Copy link
Member Author

ferjm commented Aug 27, 2018

r? @Manishearth
@Manishearth Manishearth merged commit 8c3b601 into servo:master Aug 27, 2018
@ferjm ferjm deleted the ferjm:decoder.channels branch Aug 28, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Manishearth Manishearth

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
@ferjm @Manishearth
You can’t perform that action at this time.