Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upAdd gstreamer deps to travis #122
Conversation
|
Added the missing target keys, r=me if travis passes |
|
Hmm... I am not able to reproduce this panic locally :\ |
|
Same, can't repro locally. This is weird. Maybe it's an intermittent? Can't see why but that would explain why params_connect wasn't affected (it does basically the same thing) |
|
Might be worth adding the |
7bd605e
to
9005524
They indeed look like intermittents :( |
|
@Manishearth could we merge this PR and file a follow up issue to investigate the intermittents? This way we could at least see if a PR breaks the build. |
|
Uh, sure, my concern is that this prevents us from updating media in servo
until we get CI to support Android gstreamer.
On Sep 18, 2018 7:01 PM, "Fernando Jiménez Moreno" <notifications@github.com> wrote:
@Manishearth <https://github.com/Manishearth> could we merge this PR and
file a follow up issue to investigate the intermittents? This way we could
at least see if a PR breaks the build.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#122 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/ABivSH5liQ3t4-VicXjoaIjDKK-Uv-Uxks5ucPXAgaJpZM4Whk6F>
.
|
|
I don't see how this relates to Android. Are you referring to #129 maybe :)? |
|
Derp.
Yeah please merge this. Perhaps whitelist the intermittent tests with a
`grep -V`
…On Tue, Sep 18, 2018, 7:07 PM Fernando Jiménez Moreno < ***@***.***> wrote:
I don't see how this relates to Android. Are you referring to #129
<#129> maybe :)?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#122 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/ABivSOGT2H8LqMDbQGpbPz_EZNH4zWznks5ucPc0gaJpZM4Whk6F>
.
|
ferjm commentedSep 10, 2018
r? @Manishearth