Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add gstreamer deps to travis #122

Merged
merged 9 commits into from Sep 19, 2018
Merged

Add gstreamer deps to travis #122

merged 9 commits into from Sep 19, 2018

Conversation

@ferjm
Copy link
Member

ferjm commented Sep 10, 2018

@ferjm ferjm requested a review from Manishearth Sep 10, 2018
@Manishearth
Copy link
Member

Manishearth commented Sep 10, 2018

Added the missing target keys, r=me if travis passes

@jdm
Copy link
Member

jdm commented Sep 10, 2018

     Running `target/debug/params_connect2`
thread 'AudioRenderThread' panicked at 'index 128 out of range for slice of length 0', libcore/slice/mod.rs:1932:5
note: Run with `RUST_BACKTRACE=1` for a backtrace.
thread '<unnamed>' panicked at 'called `Result::unwrap()` on an `Err` value: "SendError(..)"', libcore/result.rs:979:5
fatal runtime error: failed to initiate panic, error 5
xargs: cargo: terminated by signal 6
@ferjm
Copy link
Member Author

ferjm commented Sep 10, 2018

thread 'AudioRenderThread' panicked at 'index 128 out of range for slice of length 0', libcore/slice/mod.rs:1932:5

Hmm... I am not able to reproduce this panic locally :\

@Manishearth
Copy link
Member

Manishearth commented Sep 10, 2018

Same, can't repro locally. This is weird.

Maybe it's an intermittent? Can't see why but that would explain why params_connect wasn't affected (it does basically the same thing)

@philn
Copy link
Collaborator

philn commented Sep 11, 2018

Might be worth adding the GST_DEBUG=3 env var as well.

@ferjm ferjm force-pushed the ferjm:travis branch 2 times, most recently from 7bd605e to 9005524 Sep 11, 2018
@ferjm
Copy link
Member Author

ferjm commented Sep 11, 2018

Maybe it's an intermittent? Can't see why but that would explain why params_connect wasn't affected (it does basically the same thing)

They indeed look like intermittents :( params_connect has also failed on the last run.

@ferjm ferjm force-pushed the ferjm:travis branch from 9005524 to a489c32 Sep 14, 2018
@ferjm
Copy link
Member Author

ferjm commented Sep 18, 2018

@Manishearth could we merge this PR and file a follow up issue to investigate the intermittents? This way we could at least see if a PR breaks the build.

@Manishearth
Copy link
Member

Manishearth commented Sep 18, 2018

@ferjm
Copy link
Member Author

ferjm commented Sep 18, 2018

I don't see how this relates to Android. Are you referring to #129 maybe :)?

@Manishearth
Copy link
Member

Manishearth commented Sep 18, 2018

@ferjm ferjm force-pushed the ferjm:travis branch from a489c32 to a2e0be2 Sep 19, 2018
@ferjm ferjm merged commit 3292937 into servo:master Sep 19, 2018
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@ferjm ferjm deleted the ferjm:travis branch Sep 19, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
You can’t perform that action at this time.