Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upPass down ChannelInfo for nodes #124
Merged
Conversation
|
Looks good. Thanks! |
bors-servo
added a commit
to servo/servo
that referenced
this pull request
Sep 12, 2018
Pass through channel settings in AudioNode constructor Most audionodes let you pass in channel count/etc settings in their constructors, and have different defaults. Using the `create_node` argument added in servo/media#124 , this passes that information through. r? @ferjm. <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/21674) <!-- Reviewable:end -->
bors-servo
added a commit
to servo/servo
that referenced
this pull request
Sep 12, 2018
Pass through channel settings in AudioNode constructor Most audionodes let you pass in channel count/etc settings in their constructors, and have different defaults. Using the `create_node` argument added in servo/media#124 , this passes that information through. r? @ferjm. <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/21674) <!-- Reviewable:end -->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Manishearth commentedSep 11, 2018
The constructors get to set these. Many nodes have additional constraints but these constraints are implemented by the DOM.
r? @ferjm