New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement BiquadFilterNode #131

Merged
merged 8 commits into from Sep 19, 2018

Conversation

Projects
None yet
2 participants
@Manishearth
Member

Manishearth commented Sep 18, 2018

This contains all the code BiquadFilterNode should need, but I haven't had a chance to test it yet.

However, there are lots of equations here, so I thought I'd post it early to get a head start on review.

Note that for the actual processing code I'm using the formula from WebAudio/web-audio-api#1758 .

r? @ferjm

@Manishearth Manishearth force-pushed the Manishearth:biquad branch from 81dd962 to c34dd49 Sep 18, 2018

@Manishearth Manishearth force-pushed the Manishearth:biquad branch from c34dd49 to 36c14ff Sep 18, 2018

@Manishearth Manishearth changed the title from [WIP] Implement BiquadFilterNode to Implement BiquadFilterNode Sep 19, 2018

@Manishearth

This comment has been minimized.

Member

Manishearth commented Sep 19, 2018

Added a test; I verified it works by aurally comparing it with Firefox.

r? @ferjm

@ferjm ferjm merged commit 14de119 into servo:master Sep 19, 2018

0 of 2 checks passed

continuous-integration/travis-ci/pr The Travis CI build failed
Details
continuous-integration/travis-ci/push The Travis CI build failed
Details

@ferjm ferjm deleted the Manishearth:biquad branch Sep 19, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment