Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upImplement BiquadFilterNode #131
Merged
+403
−7
Conversation
Manishearth
changed the title
|
Added a test; I verified it works by aurally comparing it with Firefox. r? @ferjm |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Manishearth commentedSep 18, 2018
This contains all the code BiquadFilterNode should need, but I haven't had a chance to test it yet.
However, there are lots of equations here, so I thought I'd post it early to get a head start on review.
Note that for the actual processing code I'm using the formula from WebAudio/web-audio-api#1758 .
r? @ferjm