Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upgstreamer: set size to appsrc if instantiated #134
Conversation
|
r=me, waiting for travis |
|
It seems that we can remove PlayerInner.input_size |
| @@ -195,6 +195,13 @@ impl Player for GStreamerPlayer { | |||
|
|
|||
| fn set_input_size(&self, size: u64) { | |||
| self.inner.lock().unwrap().set_input_size(size); | |||
| if let Some(ref mut appsrc) = self.inner.lock().unwrap().appsrc { | |||
| if size > 0 { | |||
| appsrc.set_size(size as i64); | |||
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
ceyusa
Sep 25, 2018
Author
Contributor
It seems that we can remove PlayerInner.input_size
If the user sets the input_size() before calling setup() the data will be lost.
Should we also set max-bytes here? (i.e. 10% of size)
I experimented with it yesterday, but it didn't force a quicker metadata extraction. In my opinion, an EOF in the network doesn't mean a EOS in the video processing. We would wait for EOS or an error from the player.
This comment has been minimized.
This comment has been minimized.
ferjm
Sep 26, 2018
Member
If the user sets the input_size() before calling setup() the data will be lost.
Fair enough. Let's add a comment about that to make sure that we don't remove it in the future.
This comment has been minimized.
This comment has been minimized.
ferjm
Sep 26, 2018
Member
I experimented with it yesterday, but it didn't force a quicker metadata extraction. In my opinion, an EOF in the network doesn't mean a EOS in the video processing. We would wait for EOS or an error from the player.
For reference, this was fixed by servo/servo@1c73c72
|
It seems that we broke the audio decoder at some point #136 |
ceyusa commentedSep 24, 2018
No description provided.