Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upHandle audio decoder errors #139
Merged
+331
−254
Conversation
|
r=me |
| let pipeline_ = pipeline.downgrade(); | ||
| let callbacks_ = callbacks.clone(); | ||
|
|
||
| Builder::new() |
This comment has been minimized.
This comment has been minimized.
Manishearth
Oct 1, 2018
Member
I feel like we should be able to do this in the same thread, but no big deal if we can't.
This comment has been minimized.
This comment has been minimized.
sdroege
Oct 1, 2018
Contributor
You could integrate it into an existing event loop via e.g. the fd (it becomes readable once you can pop a message), or by using set_sync_bus_handler() and from there dispatching the message to your event loop (and returning Drop) and not doing anything else
This comment has been minimized.
This comment has been minimized.
Manishearth
Oct 1, 2018
Member
Ah, set_sync_bus_handler was what I was looking for. We can have that send an Error() message to the event loop
This comment has been minimized.
This comment has been minimized.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
ferjm commentedOct 1, 2018
No description provided.