Skip to content

/ media

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Player API: make constructor infalible and setup private #141

Merged
merged 1 commit into from Oct 2, 2018
Merged

Player API: make constructor infalible and setup private #141

merged 1 commit into from Oct 2, 2018

Conversation

@ferjm
Copy link
Member

ferjm commented Oct 2, 2018

No description provided.

@ferjm
Player API: make constructor infalible and setup private
Loading status checks…
dc1f725
@ferjm
Copy link
Member Author

ferjm commented Oct 2, 2018

r? @ceyusa
@ceyusa
Copy link
Contributor

ceyusa commented Oct 2, 2018

lgtm

r+
@ferjm ferjm merged commit 378860f into servo:master Oct 2, 2018
1 check failed
1 check failed
continuous-integration/travis-ci/pr The Travis CI build failed
Details
@ferjm ferjm deleted the ferjm:player.api branch Oct 2, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
@ferjm @ceyusa
You can’t perform that action at this time.