Skip to content

/ media

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle and expose Player errors #143

Merged
merged 3 commits into from Oct 3, 2018
Merged

Handle and expose Player errors #143

merged 3 commits into from Oct 3, 2018
+307 −230

Conversation

@ferjm
Copy link
Member

ferjm commented Oct 3, 2018

No description provided.

ferjm added 2 commits Oct 3, 2018
@ferjm
Expose Player errors
9e3aa98
@ferjm
rustfmt examples
Loading status checks…
49ca278
@ferjm
Copy link
Member Author

ferjm commented Oct 3, 2018

r? @ceyusa
@ceyusa
Copy link
Contributor

ceyusa commented Oct 3, 2018

More than code review, for me was Rust learning :) thanks

r+
@ferjm
Add PlayerError description and improve code readability
Loading status checks…
7c83cc7
@ferjm ferjm merged commit 36c3b9f into servo:master Oct 3, 2018
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@ferjm ferjm deleted the ferjm:player.errors branch Oct 3, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
@ferjm @ceyusa
You can’t perform that action at this time.