Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upAndroid cleanup #145
Merged
Android cleanup #145
+101
−174
Conversation
|
r? @Manishearth |
| @@ -0,0 +1,32 @@ | |||
| if [ "$#" -ne 1 ]; then | |||
This comment has been minimized.
This comment has been minimized.
…atus
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
ferjm commentedOct 5, 2018
•
edited
We were previously downloading and setting up the GStreamer dependencies for Android while building the
servo-media-gstreamercrate. But a user trying to use this crate on Android is also required to fetch the GStreamer dependencies to set up the JNI related stuff. This is the case for Servo since we enabled this dependency for Android. Which means that we are doing this download and setup twice.This PR moves the responsibility of fetching and setting up the GStreamer dependencies for Android to the user of this crate, so the duplication is avoided.
I added a script to ease the bootstrap process for Android and updated the README accordingly.