Skip to content

/ media

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Various bugfixes #148

Merged
merged 6 commits into from Oct 11, 2018
Merged

Various bugfixes #148

merged 6 commits into from Oct 11, 2018

Conversation

@Manishearth
Copy link
Member

Manishearth commented Oct 10, 2018 •
edited

Fixes #147

This fixes almost all the biquad failures, as well as some analyser node and buffer node failures.

More information for why the fix was necessary can be found in the individual commit messages

r? @ferjm
@Manishearth Manishearth force-pushed the Manishearth:fixes branch from 7329305 to d1bba5e Oct 10, 2018
@Manishearth
Copy link
Member Author

Manishearth commented Oct 10, 2018

The test fixes won't show up unless we also fix servo/servo#21887
@Manishearth Manishearth mentioned this pull request Oct 10, 2018
Merged
bors-servo added a commit to servo/servo that referenced this pull request Oct 10, 2018
@bors-servo
Auto merge of #21906 - Manishearth:minor-webaudio-fixes, r=<try>
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
41e613d 
Minor WebAudio fixes

Stuff I discovered whilst working on servo/media#148

r? @ferjm

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/21906)
<!-- Reviewable:end -->
Manishearth added 3 commits Oct 10, 2018
@Manishearth
Handle other silence case in Block::sum()
6ad4967
@Manishearth
Handle dirtying of AudioParams with SetValue events
0d78e49 
Currently, doing things like `biquad.frequency = 5` will not update the
filter's internal coefficients since SetValue events bypass the other
events.
@Manishearth
Use f64s internally in BiquadFilterNode
ed56cee 
The WPT tests exhibit differences otherwise
@Manishearth Manishearth force-pushed the Manishearth:fixes branch from d1bba5e to 8f62925 Oct 10, 2018
bors-servo added a commit to servo/servo that referenced this pull request Oct 11, 2018
@bors-servo
Auto merge of #21906 - Manishearth:minor-webaudio-fixes, r=ferjm
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
abde35f 
Minor WebAudio fixes

Stuff I discovered whilst working on servo/media#148

r? @ferjm

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/21906)
<!-- Reviewable:end -->
bors-servo added a commit to servo/servo that referenced this pull request Oct 11, 2018
@bors-servo
Auto merge of #21906 - Manishearth:minor-webaudio-fixes, r=ferjm
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
588525c 
Minor WebAudio fixes

Stuff I discovered whilst working on servo/media#148

r? @ferjm

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/21906)
<!-- Reviewable:end -->
@ferjm
ferjm reviewed Oct 11, 2018
View changes
Copy link
Member

ferjm left a comment •
edited

Sorry I couldn't get to this before you :\

The code looks good at first glance. But it seems to be causing permanent failures for some tests.
bors-servo added a commit to servo/servo that referenced this pull request Oct 11, 2018
@bors-servo
Auto merge of #21906 - Manishearth:minor-webaudio-fixes, r=ferjm
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
7c6ebeb 
Minor WebAudio fixes

Stuff I discovered whilst working on servo/media#148

r? @ferjm

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/21906)
<!-- Reviewable:end -->
bors-servo added a commit to servo/servo that referenced this pull request Oct 11, 2018
@bors-servo
Auto merge of #21906 - Manishearth:minor-webaudio-fixes, r=ferjm
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
ddcb72f 
Minor WebAudio fixes

Stuff I discovered whilst working on servo/media#148

r? @ferjm

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/21906)
<!-- Reviewable:end -->
Manishearth added 3 commits Oct 10, 2018
@Manishearth
Redo AudioScheduledSourceNode handling
1716c13 
Fixes #147

`.start(nonzero)` was broken before this. This fixes it, and adds
support for starting and ending within a block.
@Manishearth
Add limits for biquad filter node
d5a9855 
These aren't mentioned in the spec but must be there to avoid NaNs.
Copied from Servo.
@Manishearth
Second argument of .update_parameters is a tick offset
Loading status checks…
d1caba2
@Manishearth Manishearth force-pushed the Manishearth:fixes branch from 8f62925 to d1caba2 Oct 11, 2018
@Manishearth
Copy link
Member Author

Manishearth commented Oct 11, 2018

Fixed
@ferjm ferjm merged commit cbcea8c into servo:master Oct 11, 2018
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@ferjm ferjm deleted the Manishearth:fixes branch Oct 11, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ferjm ferjm

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

AudioScheduledSourceNode handling is buggy and `.start(offset)` doesn't work right
2 participants
@Manishearth @ferjm
You can’t perform that action at this time.