Skip to content

/ media

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Various bugfixes #148

Merged
merged 6 commits into from Oct 11, 2018
Merged

Various bugfixes #148

merged 6 commits into from Oct 11, 2018
+203 −71

Commits on Oct 10, 2018

  1. Handle other silence case in Block::sum()

    @Manishearth
    Manishearth committed Oct 10, 2018
    6ad4967

  2. Handle dirtying of AudioParams with SetValue events 

    Currently, doing things like `biquad.frequency = 5` will not update the
filter's internal coefficients since SetValue events bypass the other
events.
    @Manishearth
    Manishearth committed Oct 10, 2018
    0d78e49

  3. Use f64s internally in BiquadFilterNode 

    The WPT tests exhibit differences otherwise
    @Manishearth
    Manishearth committed Oct 10, 2018
    ed56cee

Commits on Oct 11, 2018

  1. Redo AudioScheduledSourceNode handling 

    Fixes #147

`.start(nonzero)` was broken before this. This fixes it, and adds
support for starting and ending within a block.
    @Manishearth
    Manishearth committed Oct 11, 2018
    1716c13

  2. Add limits for biquad filter node 

    These aren't mentioned in the spec but must be there to avoid NaNs.
Copied from Servo.
    @Manishearth
    Manishearth committed Oct 11, 2018
    d5a9855

  3. Second argument of .update_parameters is a tick offset

    @Manishearth
    Manishearth committed Oct 11, 2018
    Loading status checks…
    d1caba2
You can’t perform that action at this time.