Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upWait for Eos message on the bus for signalling global end-of-stream #152
Conversation
|
This works locally, I can no longer reproduce the crash. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
sdroege commentedOct 12, 2018
Each appsink will signal eos individually and considering the first
one's eos as the global end-of-stream might cause the pipeline to be
shut down before all other appsinks are done processing their data.
The Eos message on the bus is only sent once all sinks are
end-of-stream.
Fixes #151
Untested but should fix the race condition. I've also added the line to send something to the mpsc sender because a few lines below a comment claims that we
// Wait until we get an error or EOS., and only the error cases were covered.