Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign up[Player API] Expose media timeline data #155
Merged
Conversation
|
r? @ceyusa |
| if let Some(seconds) = position.seconds() { | ||
| let inner = inner_clone.lock().unwrap(); | ||
| inner.notify(PlayerEvent::PositionChanged(seconds)); | ||
| } |
This comment has been minimized.
This comment has been minimized.
ceyusa
Oct 16, 2018
Contributor
by default it updates de position each 100 ms
I wonder if should configure the interval to 1sec to avoid CPU consumution
This comment has been minimized.
This comment has been minimized.
ferjm
Oct 17, 2018
Author
Member
I ended up setting the interval to 0.5 seconds. I run some tests with 1 second interval and I saw some position updates missing.
|
r+ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
ferjm commentedOct 16, 2018
This is required to implement the details of https://html.spec.whatwg.org/multipage/media.html#offsets-into-the-media-resource