New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Player seek #157

Merged
merged 12 commits into from Oct 23, 2018

Conversation

Projects
None yet
2 participants
@ferjm
Member

ferjm commented Oct 18, 2018

No description provided.

@ferjm ferjm changed the title from [WIP] Player seek to Player seek Oct 19, 2018

@ferjm

This comment has been minimized.

Member

ferjm commented Oct 19, 2018

r? @ceyusa

@@ -47,6 +47,8 @@ fn metadata_from_media_info(media_info: &PlayerMediaInfo) -> Result<Metadata, ()
.get_container_format()
.unwrap_or_else(|| "".to_owned());
let seekable = media_info.is_seekable();

This comment has been minimized.

@ceyusa

ceyusa Oct 19, 2018

Contributor

As this flag is highly dependent on if the user set set_stream_type(), but is value is, if the use set Seekable{Fast}, to know if the media container demuxer is capable of seeking. But in theory we should control the installed demuxers and which are usable by us.

So, I'm not really sure if this metadata is required.

appsrc.set_stream_type(match seekable {
Seekable::NonSeekable => gst_app::AppStreamType::Stream,
Seekable::Seekable => gst_app::AppStreamType::Seekable,
Seekable::SeekableFast => gst_app::AppStreamType::RandomAccess,

This comment has been minimized.

@ceyusa

ceyusa Oct 19, 2018

Contributor

I'm not sure if SeekableFast makes sense in the Servo's context, since it depends in the FetchReponseListener's methods.

@@ -465,105 +489,43 @@ impl GStreamerPlayer {
}
}
macro_rules! inner_player_proxy {

This comment has been minimized.

@ceyusa

ceyusa Oct 19, 2018

Contributor

fancy!

@ferjm ferjm merged commit ade34e8 into servo:master Oct 23, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@ferjm ferjm deleted the ferjm:seek branch Oct 23, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment