Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upPlayer seek #157
Merged
Player seek #157
Conversation
|
r? @ceyusa |
backends/gstreamer/src/player.rs
Outdated
| @@ -47,6 +47,8 @@ fn metadata_from_media_info(media_info: &PlayerMediaInfo) -> Result<Metadata, () | |||
| .get_container_format() | |||
| .unwrap_or_else(|| "".to_owned()); | |||
|
|
|||
| let seekable = media_info.is_seekable(); | |||
This comment has been minimized.
This comment has been minimized.
ceyusa
Oct 19, 2018
Contributor
As this flag is highly dependent on if the user set set_stream_type(), but is value is, if the use set Seekable{Fast}, to know if the media container demuxer is capable of seeking. But in theory we should control the installed demuxers and which are usable by us.
So, I'm not really sure if this metadata is required.
backends/gstreamer/src/player.rs
Outdated
| appsrc.set_stream_type(match seekable { | ||
| Seekable::NonSeekable => gst_app::AppStreamType::Stream, | ||
| Seekable::Seekable => gst_app::AppStreamType::Seekable, | ||
| Seekable::SeekableFast => gst_app::AppStreamType::RandomAccess, |
This comment has been minimized.
This comment has been minimized.
ceyusa
Oct 19, 2018
Contributor
I'm not sure if SeekableFast makes sense in the Servo's context, since it depends in the FetchReponseListener's methods.
| @@ -465,105 +489,43 @@ impl GStreamerPlayer { | |||
| } | |||
| } | |||
|
|
|||
| macro_rules! inner_player_proxy { | |||
This comment has been minimized.
This comment has been minimized.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
ferjm commentedOct 18, 2018
No description provided.