New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implemented constant_source #164
Merged
+283
−43
Merged
Changes from 1 commit
Commits
Show all changes
76 commits
Select commit
Hold shift + click to select a range
b5e153a
added oscillator.rs
5318fc6
Added example oscillator node file, and code to handle sine, sawtooth…
arvindmohan9683 2a794c4
Implemented triangle
arvindmohan9683 c13e4e3
Implemented Triangle and modified example file
arvindmohan9683 90891d7
ready for pull request
arvindmohan9683 829225c
removed extra print statements
arvindmohan9683 5d8cdfc
Formatted files from previous commit using rustfmt
Avanthikaa ed2742c
Incomplete Constructor for periodicWvaeOptions
arvindmohan9683 683699d
Merge branch 'master' of https://github.com/Avanthikaa/media
arvindmohan9683 b0dcf9b
Added file constant_node.rs with gain_node code
4f7fcc1
Added functions and classes for Constant_source.rs
arvindmohan9683 2560800
Working imports for constant source node
arvindmohan9683 cb52d33
renamed constant_source_node to constant_source
697a456
renamed constant_source_node to constant_source
d9f94d2
Added Custom Periodic Wave Options
Priyankha12 0426b9c
ConstantSourceNode commit
Priyankha12 1045217
Periodic wave using vectors
Avanthikaa 32c37cf
Reverting changes for pull request
Avanthikaa 800f684
Ran rustfmt on modified files
Avanthikaa e437279
Ran rustfmt on constant_node and related files
Avanthikaa 5d6fbe8
removed explicit silence check
arvindmohan9683 4047212
altered debug.assert statement
arvindmohan9683 4dae6e0
Derived AudioSchedulerSourceNode in constant source
arvindmohan9683 deb3bef
added example for constant source node
84a517a
Added message handler to constant_source
arvindmohan9683 76a0a44
completed rustfmt on constantSourceNode and it's example
3763c61
added oscillator.rs
7ef514a
Added example oscillator node file, and code to handle sine, sawtooth…
arvindmohan9683 8392723
Implemented triangle
arvindmohan9683 99bfd89
Implemented Triangle and modified example file
arvindmohan9683 221bc4a
ready for pull request
arvindmohan9683 87a1351
removed extra print statements
arvindmohan9683 43b8b20
Incomplete Constructor for periodicWvaeOptions
arvindmohan9683 16f2a98
Formatted files from previous commit using rustfmt
Avanthikaa ac4fb92
Added file constant_node.rs with gain_node code
3d3c7b6
Added functions and classes for Constant_source.rs
arvindmohan9683 6be0677
Working imports for constant source node
arvindmohan9683 5c2ce7b
renamed constant_source_node to constant_source
8141782
renamed constant_source_node to constant_source
e3b059e
Periodic wave using vectors
Avanthikaa 0dfe431
Reverting changes for pull request
Avanthikaa e4a76a4
Ran rustfmt on modified files
Avanthikaa e4a8d7d
Ran rustfmt on constant_node and related files
Avanthikaa 7d2ef49
removed explicit silence check
arvindmohan9683 9c12a50
altered debug.assert statement
arvindmohan9683 2f3f2f2
Derived AudioSchedulerSourceNode in constant source
arvindmohan9683 97efbe0
added example for constant source node
6e3b79a
Added message handler to constant_source
arvindmohan9683 c08eab6
Added .DS_Store to gitignore
c42aa15
modified constant_source example
9b83e94
removed conflicts
29f1fd3
removed conflicts
87aefce
Normalizing the custom wave
Priyankha12 477c704
Merging changes
Priyankha12 af3d76a
Working imports for constant source node
arvindmohan9683 50fce97
renamed constant_source_node to constant_source
72f04dc
renamed constant_source_node to constant_source
3121311
Periodic wave using vectors
Avanthikaa e4b7ee2
Reverting changes for pull request
Avanthikaa 9086eef
Ran rustfmt on modified files
Avanthikaa 5180cde
Ran rustfmt on constant_node and related files
Avanthikaa 611d423
removed explicit silence check
arvindmohan9683 119bd7e
altered debug.assert statement
arvindmohan9683 1001525
Derived AudioSchedulerSourceNode in constant source
arvindmohan9683 08e0ae7
added example for constant source node
64e2655
Added message handler to constant_source
arvindmohan9683 128a526
Added .DS_Store to gitignore
96cf7b8
Fixed constant_source example, minor changes in other examples
arvindmohan9683 3aa2ce3
Local changes
Priyankha12 ec6fc6c
Removed audio/src/constant_source.rs
Priyankha12 dd93f56
Ran rustfmt on modified files
Priyankha12 7e65252
Update .gitignore
Priyankha12 6824ee6
Removed .DS_Store
Priyankha12 aca99b7
Merge branch 'master' of https://github.com/Avanthikaa/media into new…
Priyankha12 82a63f4
Made changes for pull request
Avanthikaa bbd207f
Removed periodic_wave_options from constructor
arvindmohan9683 File filter...
Filter file types
Jump to…
Jump to file
Failed to load files.
Added functions and classes for Constant_source.rs
- Loading branch information
commit 4f7fcc14223a25e719b076abed2b7af9560dc68a
ProTip!
Use n and p to navigate between commits in a pull request.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
According to the spec,
ConstantSourceNodeinherits fromAudioScheduledSourceNode. So we need to deriveAudioScheduledSourceNodeas well:Deriving
AudioScheduledSourceNodeadds all these functions (should_play_at,start, etc.), so you will also need to add the parameters used in them:start_at,stop_atandonended_callback.I see that you used
GainNodeas an example to develop this node. I would useOscillatorNodeinstead as a better example, as it inherits fromAudioScheduledSourceNodeas well.