Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upCheck that we have the required elements to instantiate a gst-player #167
+9
−0
Conversation
| @@ -234,6 +234,14 @@ impl GStreamerPlayer { | |||
| return Ok(()); | |||
| } | |||
|
|
|||
| // Check that we actually have the elements that we | |||
| // need to make this work. | |||
| for element in vec!["playbin", "queue"].iter() { | |||
This comment has been minimized.
This comment has been minimized.
sdroege
Nov 29, 2018
Contributor
Looks good, that should cover the worst setup problems on people's systems at least. It might still not be able to decode a specific stream because of missing codecs, but for that you get a proper error during runtime.
This comment has been minimized.
This comment has been minimized.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
ferjm commentedNov 29, 2018
r? @sdroege