New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check that we have the required elements to instantiate a gst-player #167

Merged
merged 1 commit into from Nov 29, 2018

Conversation

Projects
None yet
2 participants
@ferjm
Member

ferjm commented Nov 29, 2018

@@ -234,6 +234,14 @@ impl GStreamerPlayer {
return Ok(());
}

// Check that we actually have the elements that we
// need to make this work.
for element in vec!["playbin", "queue"].iter() {

This comment has been minimized.

@sdroege

sdroege Nov 29, 2018

Contributor

Looks good, that should cover the worst setup problems on people's systems at least. It might still not be able to decode a specific stream because of missing codecs, but for that you get a proper error during runtime.

This comment has been minimized.

@ferjm

ferjm Nov 29, 2018

Member

Yes, I think we are already reporting decoding issues.

Thanks!

@ferjm ferjm merged commit f90235b into servo:master Nov 29, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@ferjm ferjm deleted the ferjm:player.construction.errors branch Nov 29, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment