Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upAdding support for set_volume to the trait Player #170
Conversation
Implementing the set_volume from Player Trait into the DummyPlayer Adding set_volume to the GSTREAMER player
lucasfantacuci
force-pushed the
lucasfantacuci:implement_html_media_element_volume_attribute
branch
from
d8ce134
to
abb79e6
lucasfantacuci
changed the title
|
Thanks! |
lucasfantacuci
deleted the
lucasfantacuci:implement_html_media_element_volume_attribute
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
lucasfantacuci commentedNov 30, 2018
Related with servo/servo#22292