Adding support for set_volume to the trait Player#170
Merged
ferjm merged 1 commit intoservo:masterfrom Dec 3, 2018
Merged
Conversation
Implementing the set_volume from Player Trait into the DummyPlayer Adding set_volume to the GSTREAMER player
lucasfantacuci
force-pushed
the
implement_html_media_element_volume_attribute
branch
from
d8ce134 to
abb79e6
Compare
4 tasks
lucasfantacuci
changed the title
ferjm
approved these changes
Dec 3, 2018
Contributor
|
Thanks! |
lucasfantacuci
deleted the
implement_html_media_element_volume_attribute
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related with servo/servo#22292