Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upQueue a/v data while player is setting up #171
Merged
Conversation
|
@bors-servo r+ |
|
appsrc uses a queue internally, why not increase its size? |
|
That's a great question :D. I'll revert and use appsrc's internal queue. Thanks! |
|
Actually, we can handle this in a different way. We can make the player signal when it's ready and do not start any resource request until we get that signal, this way we won't need to queue any data. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
ferjm commentedDec 6, 2018
r? @jdm