Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upsome cleanups and use videoframe API #172
Merged
+28
−45
Conversation
|
@ferjm r? |
| Ok(Frame::new( | ||
| info.width() as i32, | ||
| info.height() as i32, | ||
| Arc::new(data.to_vec()), |
This comment has been minimized.
This comment has been minimized.
sdroege
Dec 7, 2018
•
Contributor
This still copies like it did before by requiring to have a Vec<u8> in the API. Ideally you would change the API so that it takes an Arc<AsRef<[u8]>> instead: in that case you could simply pass the return value of buffer.into_mapped_buffer_readable() in there.
My old servo branch had it implemented without copying similar to that.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
ceyusa commentedDec 7, 2018