Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

some cleanups and use videoframe API #172

Merged
merged 2 commits into from Dec 7, 2018
Merged

some cleanups and use videoframe API #172

merged 2 commits into from Dec 7, 2018

Conversation

@ceyusa
Copy link
Contributor

ceyusa commented Dec 7, 2018

  • Some cleanups to avoid multiple versions of some dependencies
  • Use VideoFrame from gstreamer-video (adding a new dependency). Also, If I understand correctly, this will save a copy of the frame.
@ceyusa
Copy link
Contributor Author

ceyusa commented Dec 7, 2018

@ferjm r?

@ferjm
ferjm approved these changes Dec 7, 2018
@ferjm ferjm merged commit 352072f into servo:master Dec 7, 2018
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@ferjm ferjm deleted the ceyusa:videoframe branch Dec 7, 2018
Ok(Frame::new(
info.width() as i32,
info.height() as i32,
Arc::new(data.to_vec()),

This comment has been minimized.

@sdroege

sdroege Dec 7, 2018

Contributor

This still copies like it did before by requiring to have a Vec<u8> in the API. Ideally you would change the API so that it takes an Arc<AsRef<[u8]>> instead: in that case you could simply pass the return value of buffer.into_mapped_buffer_readable() in there.

My old servo branch had it implemented without copying similar to that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.