Skip to content

/ media

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove RateChanged player event #175

Merged
merged 1 commit into from Dec 20, 2018
Merged

Remove RateChanged player event #175

merged 1 commit into from Dec 20, 2018

Conversation

@ferjm
Copy link
Member

ferjm commented Dec 19, 2018

There is no way the playback rate can change unless the client changes it through the API, so this event is useless and unfortunately the cause of a deadlock.
@ferjm
Remove RateChanged player event
Loading status checks…
b345f3e
@ferjm
Copy link
Member Author

ferjm commented Dec 19, 2018

r? @sdroege
@ferjm ferjm mentioned this pull request Dec 19, 2018
Merged
3 of 3 tasks complete
@ceyusa
Copy link
Contributor

ceyusa commented Dec 20, 2018

r+
@ferjm ferjm merged commit 35014ba into servo:master Dec 20, 2018
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@ferjm ferjm deleted the ferjm:fix_set_rate branch Dec 20, 2018
@ferjm
Copy link
Member Author

ferjm commented Dec 20, 2018

Thanks!
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
@ferjm @ceyusa
You can’t perform that action at this time.