Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upUse a Once per Player init #177
Merged
Conversation
|
r? @Manishearth |
|
This is causing a bunch of WPTs timeouts servo/servo#22522 (comment) |
|
Why not just make |
ferjm
force-pushed the
ferjm:do.not.use.once.player.init
branch
from
5a433f3
to
5faa03d
|
@Manishearth done. Not sure if I can get rid of the |
ferjm
changed the title
|
r+ travis doesn't seem to like the PR |
|
Yeah, Travis is broken since the migration. I don't know exactly why yet. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
ferjm commentedJan 9, 2019
•
edited
We need an init flag per Player instance, not a global flag. Regarding this question I believe the usage of
Ordering::Relaxedis fine here as it is harmless to send the unlock message twice.