New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Buffering and media cache #179

Merged
merged 18 commits into from Jan 16, 2019

Conversation

Projects
None yet
3 participants
@ferjm
Copy link
Member

ferjm commented Jan 10, 2019

No description provided.

@ferjm ferjm changed the title [WIP] Buffering / cache Buffering and media cache Jan 15, 2019

@ferjm ferjm force-pushed the ferjm:buffering branch from 32c12e0 to e985a0b Jan 15, 2019

@ferjm

This comment has been minimized.

Copy link
Member Author

ferjm commented Jan 15, 2019

r? @ceyusa

@ceyusa
Copy link
Contributor

ceyusa left a comment

I would squash the commit of GstBin with the previous one to avoid reviewing it twice :)

Show resolved Hide resolved Cargo.toml Outdated
Show resolved Hide resolved backends/gstreamer/source-element/src/source.rs Outdated
Show resolved Hide resolved backends/gstreamer/source-element/src/source.rs Outdated
Show resolved Hide resolved backends/gstreamer/source-element/src/source.rs Outdated
Show resolved Hide resolved backends/gstreamer/src/player.rs
Show resolved Hide resolved backends/gstreamer/src/player.rs Outdated
Show resolved Hide resolved backends/gstreamer/source-element/src/source.rs Outdated
@@ -20,6 +20,7 @@ use std::time;
use std::u64;

const MAX_SRC_QUEUE_SIZE: u64 = 50 * 1024 * 1024; // 50 MB.
const MAX_BUFFER_SIZE: i32 = 500 * 1024;

This comment has been minimized.

@ceyusa

ceyusa Jan 15, 2019

Contributor

why this magic number?

This comment has been minimized.

@ferjm

ferjm Jan 15, 2019

Author Member

I got it from Gecko. I guess we could check disk space and make this more dynamic, but I'd prefer to do that in a follow up.

Show resolved Hide resolved backends/gstreamer/src/player.rs Outdated
Show resolved Hide resolved backends/gstreamer/src/player.rs Outdated

@ferjm ferjm force-pushed the ferjm:buffering branch from e985a0b to 1ad9531 Jan 16, 2019

@ceyusa

This comment has been minimized.

Copy link
Contributor

ceyusa commented Jan 16, 2019

r+ :)

@ferjm ferjm merged commit 4bed1cd into servo:master Jan 16, 2019

@ferjm ferjm deleted the ferjm:buffering branch Jan 16, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment