Buffering and media cache #179

ferjm · 2019-01-10T17:15:50Z

No description provided.


        Set player flags to enable progressive downloading


        Handle appsrc scheduling query to report itself as bandwidth limited

ferjm · 2019-01-15T10:37:34Z

r? @ceyusa

ceyusa

I would squash the commit of GstBin with the previous one to avoid reviewing it twice :)

Cargo.toml

backends/gstreamer/source-element/src/source.rs

backends/gstreamer/src/player.rs

backends/gstreamer/source-element/src/source.rs

ceyusa · 2019-01-15T12:46:14Z

backends/gstreamer/src/player.rs

@@ -20,6 +20,7 @@ use std::time;
 use std::u64;

 const MAX_SRC_QUEUE_SIZE: u64 = 50 * 1024 * 1024; // 50 MB.
+const MAX_BUFFER_SIZE: i32 = 500 * 1024;


why this magic number?

I got it from Gecko. I guess we could check disk space and make this more dynamic, but I'd prefer to do that in a follow up.

backends/gstreamer/src/player.rs

backends/gstreamer/src/source.rs


        Introduce servosrc


        Make player play a/v again with servosrc


        Set query function on the bin appsrc ghostpad to report that we are b…

…andwidth limited


        Simplify ServoSrc.appsrc property and fix unused imports warnings


        No need to have an independent crate for servosrc


        Add flag to tell whether a media source is live or not


        Get buffering stats


        Do not allow setting the size twice


        Set player buffer size


        Cleanup and fix build errors after long rebase


        Actually return seconds and not a percentage of buffered media


        Do not set caps at the source element's source pad


        Set constant properties in servosrc


        Use ToString trait to get GLib error description


        Report bandwidth limited through servosrc overrided query method


        Check servosrc uri

ceyusa · 2019-01-16T17:32:39Z

r+ :)

ferjm added 2 commits Nov 13, 2018

Set player flags to enable progressive downloading

014606f

Handle appsrc scheduling query to report itself as bandwidth limited

7cb85f0

ferjm changed the title ~~[WIP] Buffering / cache~~ Buffering and media cache Jan 15, 2019

ferjm force-pushed the ferjm:buffering branch from 32c12e0 to e985a0b Jan 15, 2019

ceyusa reviewed Jan 15, 2019

View changes

sdroege reviewed Jan 15, 2019

View changes

backends/gstreamer/src/source.rs Outdated Show resolved Hide resolved

sdroege reviewed Jan 15, 2019

View changes

backends/gstreamer/src/source.rs Outdated Show resolved Hide resolved

ferjm added 16 commits Nov 16, 2018

Introduce servosrc

86333fe

Make player play a/v again with servosrc

0303288

Set query function on the bin appsrc ghostpad to report that we are b…

ffb7c50

…andwidth limited

Simplify ServoSrc.appsrc property and fix unused imports warnings

f0fdf0e

No need to have an independent crate for servosrc

e0a5541

Add flag to tell whether a media source is live or not

baa3b7d

Get buffering stats

cc5797d

Do not allow setting the size twice

39a5af0

Set player buffer size

a1b0752

Cleanup and fix build errors after long rebase

59141c8

Actually return seconds and not a percentage of buffered media

e21ec6d

Do not set caps at the source element's source pad

09a8ae5

Set constant properties in servosrc

0b033e5

Use ToString trait to get GLib error description

3db1a4f

Report bandwidth limited through servosrc overrided query method

adbb153

Check servosrc uri

Loading status checks…

1ad9531

ferjm force-pushed the ferjm:buffering branch from e985a0b to 1ad9531 Jan 16, 2019

ferjm merged commit 4bed1cd into servo:master Jan 16, 2019
1 check passed

1 check passed

Travis CI - Pull Request Build Passed
Details

ferjm deleted the ferjm:buffering branch Jan 16, 2019

servo / media

Buffering and media cache #179

Buffering and media cache #179

ferjm commented Jan 10, 2019

ferjm commented Jan 15, 2019

ceyusa left a comment •

edited

This comment has been minimized.

This comment has been minimized.

ceyusa commented Jan 16, 2019

servo / media

Join GitHub today

Buffering and media cache #179

Buffering and media cache #179

Conversation

ferjm commented Jan 10, 2019

ferjm commented Jan 15, 2019

ceyusa left a comment • edited

This comment has been minimized.

ceyusa Jan 15, 2019

This comment has been minimized.

ferjm Jan 15, 2019

ceyusa commented Jan 16, 2019

ceyusa left a comment •

edited