Add remote stream callback and simple abstraction for playback. #186
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @Manishearth |
|
It's not clear to me that WebRtcSignaller is really where on_add_stream belongs, but perhaps we should be looking at renaming it to something like PeerConnection. |
sdroege
reviewed
Jan 27, 2019
| @@ -1,6 +1,6 @@ | |||
| use glib::ObjectExt; | |||
| use gst::{self, BinExtManual, ElementExt, GObjectExtManualGst}; | |||
| use servo_media_webrtc::MediaStream; | |||
| use gst::{self, BinExt, BinExtManual, ElementExt, GObjectExtManualGst}; | |||
There was a problem hiding this comment.
I'd recommend simply importing glib::prelude::* and gst::prelude::* instead of the traits manually btw
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There should be no difference in behaviour as a result of these changes. They fix jdm#6.