Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upmake the build of examples optional #188
Conversation
|
You'll also need to make sure Travis runs this. I'm not sure if we should merge this, I feel like if you need to build a particular crate you should just cd to that folder and do so, that's usually how workspaces work. |
You are referring to this? https://github.com/servo/media/pull/188/checks?check_run_id=55297147
I don't need to build a particular crate. I want to build everything except the examples. I think the reasons I previously stated make it a worthwhile change. Building the examples is not essential and should not be done by default. |
Right, the
For development? In that case you probably should be building the examples too as the API isn't very stable. Otherwise just build the servo-media crate, that pulls in everything but examples. If you're pulling this in as a crate none of this matters anyway, since you won't be pulling in the examples crate. |
|
Ah, ok. I understand now. Then perhaps this PRQ is not necessary. |
|
(I'm still open to merging this if other maintainers want to) |
zimio commentedJan 27, 2019
The examples inside of the project have more dependencies than the project itself. This creates the issue that by default, if someone tries to build without any of these dependencies, the build will fail.
A better approach would be to make the build of examples optional, because they are not necessary for the library to function. They are just there for pedagogic purposes. Also, not building the examples all the time will speed up build time in downstream projects.
With this change if you run the following command no examples will be built.
If you run the following command all examples will be built.